js: Always use SOURCE_CONTINUE/SOURCE_REMOVE in later handlers

The constants are more self-explanatory (and therefore readable)
then plain true/false.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3950>
(cherry picked from commit 9fc7f3f439ae95646882dd8b60d08003a38daaf5)

diff --git a/js/gdm/authList.js b/js/gdm/authList.js
index 6575ca4c01f71b86c8e4847162d8373c9698ebb9..4873a05c58ed3b9a4ad0c9caf10d1409d515541b 100644 (file)
--- a/js/gdm/authList.js
+++ b/js/gdm/authList.js
@@ -16,6 +16,7 @@
  */
 
 import Clutter from 'gi://Clutter';
+import GLib from 'gi://GLib';
 import GObject from 'gi://GObject';
 import Meta from 'gi://Meta';
 import St from 'gi://St';
@@ -114,7 +115,7 @@ export const AuthList = GObject.registerClass({
             const laters = global.compositor.get_laters();
             laters.add(Meta.LaterType.BEFORE_REDRAW, () => {
                 this._moveFocusToItems();
-                return false;
+                return GLib.SOURCE_REMOVE;
             });
         }
     }

diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js
index 1b568cbde97326fe0e77a681a400b21631733fb5..3f2f512c9fbfdf748038e4ab9ebb4c7aa356817e 100644 (file)
--- a/js/gdm/loginDialog.js
+++ b/js/gdm/loginDialog.js
@@ -208,7 +208,7 @@ const UserList = GObject.registerClass({
             const laters = global.compositor.get_laters();
             laters.add(Meta.LaterType.BEFORE_REDRAW, () => {
                 this._moveFocusToItems();
-                return false;
+                return GLib.SOURCE_REMOVE;
             });
         }
     }

diff --git a/js/ui/dash.js b/js/ui/dash.js
index f9b55c0403b28819ea1698ab23fdba39188f374d..5037ad5f12727f46db09a2d3a535a32fb0f7c40b 100644 (file)
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -264,7 +264,7 @@ class ShowAppsIcon extends DashItemContainer {
         const laters = global.compositor.get_laters();
         laters.add(Meta.LaterType.BEFORE_REDRAW, () => {
             AppFavorites.getAppFavorites().removeFavorite(id);
-            return false;
+            return GLib.SOURCE_REMOVE;
         });
 
         return true;
@@ -978,7 +978,7 @@ export const Dash = GObject.registerClass({
                 appFavorites.moveFavoriteToPos(id, favPos);
             else
                 appFavorites.addFavoriteAtPos(id, favPos);
-            return false;
+            return GLib.SOURCE_REMOVE;
         });
 
         return true;

diff --git a/js/ui/main.js b/js/ui/main.js
index 40898e15c23d2aa998889feb4d3b7721351f3fb8..4a011f262b529ed283564d7dc6d7876c5d5ca168 100644 (file)
--- a/js/ui/main.js
+++ b/js/ui/main.js
@@ -944,7 +944,7 @@ function _queueBeforeRedraw(workId) {
         const laters = global.compositor.get_laters();
         laters.add(Meta.LaterType.BEFORE_REDRAW, () => {
             _runBeforeRedrawQueue();
-            return false;
+            return GLib.SOURCE_REMOVE;
         });
     }
 }

diff --git a/js/ui/windowManager.js b/js/ui/windowManager.js
index d654228fc0e80ee3d609cc9fcab7dc4a3013557e..f3e6c4d99cb0480a0b2549930126ccf1058e85e1 100644 (file)
--- a/js/ui/windowManager.js
+++ b/js/ui/windowManager.js
@@ -225,12 +225,12 @@ class WorkspaceTracker {
 
         if (!Meta.prefs_get_dynamic_workspaces()) {
             this._checkWorkspacesId = 0;
-            return false;
+            return GLib.SOURCE_REMOVE;
         }
 
         // Update workspaces only if Dynamic Workspace Management has not been paused by some other function
         if (this._pauseWorkspaceCheck)
-            return true;
+            return GLib.SOURCE_CONTINUE;
 
         for (i = 0; i < this._workspaces.length; i++) {
             let lastRemoved = this._workspaces[i]._lastRemovedWindow;
@@ -290,7 +290,7 @@ class WorkspaceTracker {
         }
 
         this._checkWorkspacesId = 0;
-        return false;
+        return GLib.SOURCE_REMOVE;
     }
 
     keepWorkspaceAlive(workspace, duration) {